-
Notifications
You must be signed in to change notification settings - Fork 1
compartment sets 2: reports #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 15759951865Details
💛 - Coveralls |
Collaborator
|
I'll review it after the sonata-extension is merged. |
Contributor
Author
|
waiting for this to be merged: openbraininstitute/sonata-extension#5 I have got a working solution already (from beginning to end) with an unfinished version of the nomenclature. I will wait now for the definitive decision on the spec |
98bc62f to
ba78ce2
Compare
mgeplf
reviewed
Jun 18, 2025
mgeplf
reviewed
Jun 19, 2025
mgeplf
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was not aware that the parsing and validation of
simulation_config.jsonwas done by sonata too. This is also needed to implement fully compartment sets.The change is based on this proposal openbraininstitute/sonata-extension#5Final version: https://sonata-extension.readthedocs.io/en/latest/sonata_report.html#fine-grained-compartment-report
Report::Type::compartment_set: this disallows and (sets toinvalidin the final product) thesectionsandcompartmentslines since they lose meaning if we use thecompartment_sets.jsonfile.simulation_config.jsonfor testing.sectionsorcompartmentsare presentReportto specify whichcompartment_setwe want to use