Skip to content

Conversation

@cattabiani
Copy link
Contributor

@cattabiani cattabiani commented Jun 11, 2025

I was not aware that the parsing and validation of simulation_config.json was done by sonata too. This is also needed to implement fully compartment sets.

The change is based on this proposal openbraininstitute/sonata-extension#5
Final version: https://sonata-extension.readthedocs.io/en/latest/sonata_report.html#fine-grained-compartment-report

  • new Report::Type::compartment_set: this disallows and (sets to invalid in the final product) the sections and compartments lines since they lose meaning if we use the compartment_sets.json file.
  • add a new compartment_sets report in simulation_config.json for testing.
  • add 2 tests to verify that we throw an error if sections or compartments are present
  • add new entry in Report to specify which compartment_set we want to use
  • order by gid (preserving the list ordering otherwise)

@cattabiani cattabiani self-assigned this Jun 11, 2025
@cattabiani cattabiani requested a review from mgeplf June 11, 2025 08:45
@cattabiani cattabiani marked this pull request as ready for review June 11, 2025 08:46
@coveralls
Copy link

coveralls commented Jun 11, 2025

Pull Request Test Coverage Report for Build 15759951865

Details

  • 33 of 33 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 92.674%

Totals Coverage Status
Change from base Build 15489935130: 0.08%
Covered Lines: 2353
Relevant Lines: 2539

💛 - Coveralls

@cattabiani cattabiani marked this pull request as draft June 11, 2025 08:46
@cattabiani cattabiani removed the request for review from mgeplf June 11, 2025 08:47
@mgeplf
Copy link
Collaborator

mgeplf commented Jun 11, 2025

I'll review it after the sonata-extension is merged.

@cattabiani cattabiani marked this pull request as ready for review June 11, 2025 10:04
@cattabiani
Copy link
Contributor Author

waiting for this to be merged:

openbraininstitute/sonata-extension#5

I have got a working solution already (from beginning to end) with an unfinished version of the nomenclature. I will wait now for the definitive decision on the spec

@cattabiani cattabiani requested review from mgeplf June 17, 2025 15:08
@mgeplf mgeplf force-pushed the katta/comp_sets_2 branch from 98bc62f to ba78ce2 Compare June 18, 2025 09:08
@cattabiani cattabiani merged commit 4a7c17b into master Jun 20, 2025
23 checks passed
@cattabiani cattabiani deleted the katta/comp_sets_2 branch June 20, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants