This repository was archived by the owner on Sep 11, 2023. It is now read-only.
Issue/182 normalised gsp data #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterdudfield
commented
Sep 30, 2021
| assert isinstance(gsp_pv_df, pd.DataFrame) | ||
| assert len(gsp_pv_df) == (48 + 1) * 10 | ||
| assert "datetime_gmt" in gsp_pv_df.columns | ||
| assert "generation_mw" in gsp_pv_df.columns |
There was a problem hiding this comment.
this are just moved to the file below
|
I'm just running the script to make the raw data - I think i'll wait unil that is done, before merging. Just so I dont break things my merging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Fixes issue #182
How Has This Been Tested?
add unittests
checked raw data has maximum <=1 - TODO on full set
No
Yes
Checklist: