Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Conversation

@jacobbieker
Copy link
Contributor

@jacobbieker jacobbieker commented Oct 12, 2021

Pull Request

Description

Setups up this repo sending a dispatch event whenever a push happens to this repo. This event will trigger nowcasting_dataloader to run its tests against the master branch of nowcasting_dataset on every push.

Fixes #

How Has This Been Tested?

Pushing to this branch and seeing if nowcasting_dataloader runs its tests

  • No
  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@jacobbieker jacobbieker added the enhancement New feature or request label Oct 12, 2021
@jacobbieker jacobbieker self-assigned this Oct 12, 2021
@jacobbieker
Copy link
Contributor Author

This does now cause a test to trigger in nowcasting_dataloader when there is a push to this repo. So we should know if the dataloader starts failing on our push. Not really sure how to show in this repo that that repo failed though

@@ -0,0 +1,19 @@
# This workflow will install Python dependencies, run tests and lint with a single version of Python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this need updating?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it run pytest in dataloader repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you are right. Technically it doesn't run the pytest, a workflow in dataloader sees this event and starts pytest, but you can't directly trigger pytest from a different repo

@jacobbieker jacobbieker merged commit 9601000 into main Oct 13, 2021
@jacobbieker jacobbieker deleted the jacob/dataloader-test branch October 13, 2021 07:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants