Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

try CI - PVlive errors #397

Merged
merged 3 commits into from
Nov 16, 2021
Merged

try CI - PVlive errors #397

merged 3 commits into from
Nov 16, 2021

Conversation

@peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Nov 16, 2021 •
edited
Loading

Pull Request

Description

  • try fix with context manager
  • skip pvlive tests (for the moment), keep issue alive until server is back, or we decide to do it in a different way

Fixes #395

How Has This Been Tested?

Unitests

  • No
  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@JackKelly JackKelly added the bug Something isn't working label Nov 16, 2021
@peterdudfield
Copy link
Contributor Author

peterdudfield commented Nov 16, 2021

Although this wasnt the fix, I would still like to merge this in - just waiting for tests to pass

@peterdudfield peterdudfield changed the title try using context manager try CI - PVlive errors Nov 16, 2021
@peterdudfield peterdudfield marked this pull request as ready for review November 16, 2021 13:30
jacobbieker
jacobbieker approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@jacobbieker jacobbieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

JackKelly
JackKelly approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@JackKelly JackKelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peterdudfield peterdudfield merged commit 57b6d58 into main Nov 16, 2021
@peterdudfield peterdudfield deleted the bug/395-ci-test-gsp branch November 16, 2021 14:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@JackKelly JackKelly JackKelly approved these changes

@jacobbieker jacobbieker jacobbieker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@peterdudfield peterdudfield

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 tests failing on MacOS CI build (but the same tests are passing on Linux CI build!)

4 participants

@peterdudfield @JackKelly @jacobbieker