Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Conversation

@peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Apr 8, 2022

Pull Request

Description

Make sure pv dtypes are float32 and int32

Fix '_index' for all date types to be int32 too

Fixes #624

How Has This Been Tested?

  • normal unittests

  • added checks in tests for dtype

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield self-assigned this Apr 8, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #641 (c3d5bc7) into main (9bf8cdd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #641   +/-   ##
=======================================
  Coverage   93.14%   93.15%           
=======================================
  Files          45       45           
  Lines        3049     3052    +3     
=======================================
+ Hits         2840     2843    +3     
  Misses        209      209           
Impacted Files Coverage Δ
...wcasting_dataset/data_sources/pv/pv_data_source.py 97.54% <100.00%> (+0.01%) ⬆️
nowcasting_dataset/dataset/xr_utils.py 98.55% <100.00%> (+0.04%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@jacobbieker jacobbieker merged commit 854c0bd into main May 9, 2022
@jacobbieker jacobbieker deleted the issue/624-pv-types branch May 9, 2022 11:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use minimal data types for PV

4 participants