Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Conversation

@peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Apr 11, 2022

Pull Request

Description

  • adjust sun data to be in floats
  • put v2 in leonardo and gcp
  • re run sun data source to v2

Fixes #634

How Has This Been Tested?

  • normal unittest

  • ran prepare_ml_data.py

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield self-assigned this Apr 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2022

Codecov Report

Merging #644 (192441b) into main (9bf8cdd) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #644      +/-   ##
==========================================
+ Coverage   93.14%   93.17%   +0.03%     
==========================================
  Files          45       45              
  Lines        3049     3064      +15     
==========================================
+ Hits         2840     2855      +15     
  Misses        209      209              
Impacted Files Coverage Δ
nowcasting_dataset/config/model.py 93.56% <100.00%> (+0.03%) ⬆️
...wcasting_dataset/data_sources/pv/pv_data_source.py 97.58% <100.00%> (+0.04%) ⬆️
...et/data_sources/satellite/satellite_data_source.py 94.24% <100.00%> (+0.04%) ⬆️
..._dataset/data_sources/satellite/satellite_model.py 100.00% <100.00%> (ø)
nowcasting_dataset/time.py 89.36% <100.00%> (+0.72%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@peterdudfield peterdudfield added this to the v17 dataset milestone Apr 12, 2022
@jacobbieker jacobbieker merged commit 0711c52 into main May 9, 2022
@jacobbieker jacobbieker deleted the issue/634-sun-floats branch May 9, 2022 11:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sun should probably save elevation and azimuth as float32 not int64

4 participants