Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Conversation

@peterdudfield
Copy link
Contributor

Pull Request

Description

add (non-deafult_ options to not make batches using async. This makes debugging easier sometimes

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield self-assigned this May 13, 2022
@peterdudfield peterdudfield marked this pull request as ready for review May 13, 2022 10:35
@codecov-commenter
Copy link

Codecov Report

Merging #659 (dec38eb) into main (1c749b7) will decrease coverage by 0.14%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##             main     #659      +/-   ##
==========================================
- Coverage   93.38%   93.24%   -0.15%     
==========================================
  Files          47       47              
  Lines        3192     3197       +5     
==========================================
  Hits         2981     2981              
- Misses        211      216       +5     
Impacted Files Coverage Δ
...et/data_sources/satellite/satellite_data_source.py 93.67% <ø> (ø)
nowcasting_dataset/manager/manager_live.py 91.30% <33.33%> (-7.21%) ⬇️
...wcasting_dataset/data_sources/datasource_output.py 88.63% <100.00%> (+0.40%) ⬆️
...asting_dataset/data_sources/gsp/gsp_data_source.py 91.50% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@peterdudfield peterdudfield merged commit 5050bde into main May 13, 2022
@peterdudfield peterdudfield deleted the async-option branch May 13, 2022 10:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants