Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Conversation

@peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented May 25, 2022

Pull Request

Description

add option to make sun data on the fly
Fixes #675

How Has This Been Tested?

added a unittest

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2022

Codecov Report

Merging #676 (8c0dedf) into main (fdffacf) will increase coverage by 0.00%.
The diff coverage is 96.66%.

@@           Coverage Diff           @@
##             main     #676   +/-   ##
=======================================
  Coverage   93.42%   93.42%           
=======================================
  Files          48       48           
  Lines        3316     3332   +16     
=======================================
+ Hits         3098     3113   +15     
- Misses        218      219    +1     
Impacted Files Coverage Δ
...asting_dataset/data_sources/sun/sun_data_source.py 97.43% <96.42%> (-1.01%) ⬇️
nowcasting_dataset/config/model.py 94.17% <100.00%> (+0.05%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@peterdudfield peterdudfield merged commit 68f66c2 into main May 25, 2022
@peterdudfield peterdudfield deleted the issue/675-sun-data-on-the-fly branch May 25, 2022 10:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make sun data on the go

3 participants