-
Notifications
You must be signed in to change notification settings - Fork 2
Preparation for making repo public: Post results from demo runs as PR comments #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XSD Demo Test Results on openconfig/publicall tests passed |
POSIX Demo Test Results on openconfig/publicall tests passed |
Contributor
Author
|
This PR is likely superseded by #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT SUBMIT. This PR is likely superseded by #13
The results from the demo runs will now be posted as PR comments. These comments are updated by subsequent pushes to the PR. Its purpose is to show the effects of the PR's set of tests on the public models. If new tests are added, we want to make sure that the tests either pass as expected, or fail as expected (if the test corrects a current model error).
Here is the expected workflow for adding a new test for fixing a bad pattern in the models:
Also updated README with the workflow steps above, and split existing regex tests into modules.