Skip to content

Conversation

@wenovus
Copy link
Contributor

@wenovus wenovus commented Feb 26, 2021

DO NOT SUBMIT. This PR is likely superseded by #13

The results from the demo runs will now be posted as PR comments. These comments are updated by subsequent pushes to the PR. Its purpose is to show the effects of the PR's set of tests on the public models. If new tests are added, we want to make sure that the tests either pass as expected, or fail as expected (if the test corrects a current model error).

Here is the expected workflow for adding a new test for fixing a bad pattern in the models:

  1. Someone notices a pattern is wrong.
  2. Tests are added to the openconfig/pattern-regex-tests repo, demonstrating the failure on openconfig/public.
  3. PR is merged, and a new minor version of openconfig/pattern-regex-tests is released.
  4. A PR is opened for openconfig/public that uses the new version of openconfig/pattern-regex-tests, with the corresponding fix to the pattern in the model.

Also updated README with the workflow steps above, and split existing regex tests into modules.

@github-actions
Copy link

github-actions bot commented Feb 26, 2021

XSD Demo Test Results on openconfig/public

all tests passed

@openconfig openconfig deleted a comment from github-actions bot Feb 26, 2021
@github-actions
Copy link

github-actions bot commented Feb 26, 2021

POSIX Demo Test Results on openconfig/public

all tests passed

@openconfig openconfig deleted a comment from github-actions bot Feb 26, 2021
@wenovus wenovus marked this pull request as draft March 4, 2021 01:18
@wenovus
Copy link
Contributor Author

wenovus commented Mar 4, 2021

This PR is likely superseded by #13

@wenovus wenovus closed this May 21, 2021
@wenovus wenovus deleted the add-pr-commend branch May 21, 2021 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant