Skip to content

Conversation

@wenovus
Copy link
Contributor

@wenovus wenovus commented Aug 8, 2023

No description provided.

@wenovus wenovus requested review from bstoll and robshakir August 15, 2023 00:43
@wenovus wenovus marked this pull request as ready for review August 15, 2023 00:43
@robshakir
Copy link
Member

Looks like this repo needs to be enrolled on coveralls.

@wenovus wenovus merged commit fda74fd into main Aug 17, 2023
@wenovus wenovus deleted the use-common-workflow branch August 17, 2023 16:47
@wenovus
Copy link
Contributor Author

wenovus commented Aug 17, 2023

Looks like this repo needs to be enrolled on coveralls.

Ah it's a private repo. Are we ok with coveralls accessing private repos? If not then I think it's likely safe to make it public (I can do a more in-detail scrub to make sure).

@robshakir
Copy link
Member

Just public without a subscription I believe. Happy to OSS it.

@wenovus
Copy link
Contributor Author

wenovus commented Aug 17, 2023

Just public without a subscription I believe. Happy to OSS it.

Took a look at the files, it's safe to be made public.

@robshakir
Copy link
Member

Flipped the bit! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants