This repository was archived by the owner on Jul 18, 2023. It is now read-only.
Add white underlay to images for visibility in browsers with dark mode enabled #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e enabled. Signed-off-by: Maxwell Bloch <maxwellb@users.noreply.github.com>
maxwellb
force-pushed
the
dark-mode-readability
branch
from
b03b3e8 to
ce625d6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dark mode, the images in the author's guide have readability issues. This pull request adds white underlays to the images so that the experience is unchanged in light mode, and enhanced in dark mode.