Skip to content

Conversation

@mirceamp
Copy link
Contributor

@mirceamp mirceamp commented Jun 7, 2015

@snosov1
Created the new stereo module with its specific files.

@snosov1
Copy link

snosov1 commented Jun 8, 2015

That looks fine to me. Just, please, fix the warnings, so it builds ok.

@vpisarev Vadim, what about you? Also, do we want to support the C functions and structures, like CvStereoBinaryBMState?

mirceamp added 3 commits June 15, 2015 19:54
made some extra changes to the modules so I receive no warnings

moved the opencv2/core/private.hpp from stereo_binary_sgbm.cpp to precomp.hpp
changed the ptr<StereBinaryBM> to ptr<cv::stereo::StereoBinaryBM>

modified the documentation

modified documentation for the stereo_c

documentation

doc

fixed two issues

modfified the precomp.hpp header by explicitly adding the cvdef header from core

modified comments for documentation for stereo and removed some headers

added a header and modified some function definition

test

test 2

changed exports_w to exports

removed the correct matches module
@mirceamp mirceamp force-pushed the stereoBranch branch 2 times, most recently from 9e56010 to 99e5f01 Compare June 15, 2015 18:59
@vpisarev
Copy link
Contributor

@MMp131316, thanks for the PR! Looks good! Please, remove
void filterSpeckles( InputOutputArray img, double newVal,
int maxSpeckleSize, double maxDiff,
InputOutputArray buf = noArray() );

Rect getValidDisparityROI( Rect roi1, Rect roi2,
int minDisparity, int numberOfDisparities,
int SADWindowSize );

void validateDisparity( InputOutputArray disparity, InputArray cost,
int minDisparity, int numberOfDisparities,
int disp12MaxDisp = 1 );

since they are present in calib3d. Also, add calib3d as dependency for the stereo module.

@vpisarev vpisarev self-assigned this Jun 16, 2015
@mirceamp
Copy link
Contributor Author

ok Best regards,
Muresan Mircea Paul

 On Tuesday, June 16, 2015 3:27 PM, Vadim Pisarevsky <notifications@github.com> wrote:

@MMp131316, thanks for the PR! Looks good! Please, remove
void filterSpeckles( InputOutputArray img, double newVal,
int maxSpeckleSize, double maxDiff,
InputOutputArray buf = noArray() );Rect getValidDisparityROI( Rect roi1, Rect roi2,
int minDisparity, int numberOfDisparities,
int SADWindowSize );void validateDisparity( InputOutputArray disparity, InputArray cost,
int minDisparity, int numberOfDisparities,
int disp12MaxDisp = 1 );since they are present in calib3d. Also, add calib3d as dependency for the stereo module.—
Reply to this email directly or view it on GitHub.

@mirceamp
Copy link
Contributor Author

@vpisarev Hello Vadim, I have done the what you have asked

@vpisarev
Copy link
Contributor

👍

vpisarev added a commit that referenced this pull request Jun 18, 2015
@vpisarev vpisarev merged commit af63b7a into opencv:master Jun 18, 2015
@mirceamp mirceamp deleted the stereoBranch branch June 18, 2015 16:11
allnes pushed a commit to allnes/opencv_contrib that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants