-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Stereo branch #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stereo branch #251
Conversation
|
That looks fine to me. Just, please, fix the warnings, so it builds ok. @vpisarev Vadim, what about you? Also, do we want to support the C functions and structures, like CvStereoBinaryBMState? |
Update README.md
made some extra changes to the modules so I receive no warnings moved the opencv2/core/private.hpp from stereo_binary_sgbm.cpp to precomp.hpp
changed the ptr<StereBinaryBM> to ptr<cv::stereo::StereoBinaryBM> modified the documentation modified documentation for the stereo_c documentation doc fixed two issues modfified the precomp.hpp header by explicitly adding the cvdef header from core modified comments for documentation for stereo and removed some headers added a header and modified some function definition test test 2 changed exports_w to exports removed the correct matches module
9e56010 to
99e5f01
Compare
|
@MMp131316, thanks for the PR! Looks good! Please, remove Rect getValidDisparityROI( Rect roi1, Rect roi2, void validateDisparity( InputOutputArray disparity, InputArray cost, since they are present in calib3d. Also, add calib3d as dependency for the stereo module. |
|
ok Best regards, @MMp131316, thanks for the PR! Looks good! Please, remove |
… functions and added the calib3d module in the dependency
|
@vpisarev Hello Vadim, I have done the what you have asked |
|
👍 |
@snosov1
Created the new stereo module with its specific files.