Skip to content

phase_unwrapping: add asserts, documentation for input types #2752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2020
Merged

phase_unwrapping: add asserts, documentation for input types #2752

merged 1 commit into from
Nov 17, 2020

Conversation

@berak
Copy link
Contributor

@berak berak commented Nov 17, 2020 •
edited by alalek
Loading

related to #2746

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

alalek
alalek reviewed Nov 17, 2020
View reviewed changes
modules/phase_unwrapping/src/histogramphaseunwrapping.cpp Outdated
}

CV_Assert(wPhaseMap.type() == CV_32FC1);
CV_Assert(mask.type() == CV_8UC1);
Copy link
Member

@alalek alalek Nov 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CV_CheckType(wPhaseMap.type(), CV_32FC1, "") ?

Copy link
Member

@alalek alalek Nov 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake =(
Sorry, please use CV_CheckTypeEQ(...)

@berak berak force-pushed the phase_unwrapping_input_type branch from 4029309 to a6e4a56 Compare November 17, 2020 11:50
@berak berak force-pushed the phase_unwrapping_input_type branch from a6e4a56 to 1d84f28 Compare November 17, 2020 13:17
alalek
alalek approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@opencv-pushbot opencv-pushbot merged commit 24a8823 into opencv:3.4 Nov 17, 2020
@berak berak deleted the phase_unwrapping_input_type branch November 17, 2020 16:11
@alalek alalek mentioned this pull request Nov 17, 2020
Merged
@alalek alalek mentioned this pull request Nov 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: documentation Documentation fix or update, does not affect code category: phase_unwrapping

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@berak @alalek @opencv-pushbot