This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Backport commits from dev #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongnansu
changed the title
zhongnansu
changed the title
Codecov Report
@@ Coverage Diff @@
## 7.9.1 #269 +/- ##
========================================
Coverage ? 70.10%
========================================
Files ? 32
Lines ? 1773
Branches ? 343
========================================
Hits ? 1243
Misses ? 525
Partials ? 5 Continue to review full report at Codecov.
|
zhongnansu
requested review from
davidcui1225,
joshuali925,
abbashus,
anirudha and
akbhatta
akbhatta
approved these changes
Dec 18, 2020
README.md
Outdated
| @@ -1,3 +1,9 @@ | |||
| [](https://github.com/opendistro-for-elasticsearch/kibana-reports/actions?query=workflow%3A%22Test+and+Build+Kibana+Reports%22) | |||
| [](https://github.com/opendistro-for-elasticsearch/kibana-reports/actions?query=workflow%3A%22Test+and+Build+Reports+Scheduler%22) | |||
| [](https://codecov.io/gh/opendistro-for-elasticsearch/kibana-reports) | |||
There was a problem hiding this comment.
should the path changed to 7.9.1 instead of dev?
There was a problem hiding this comment.
good catch, will change
…o-for-elasticsearch#272) * WIP create requests * Allow custom error types in validateErrorResponse * Add more test cases * Address comments * Use multiple constants instead of one variable * Move helper method to TestHelpers
zhongnansu
force-pushed
the
backport-changes
branch
from
99f44c7
to
aa579a1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Backport commits from
devbranch, which includes important bug-fixes and featuresfrom commit 461cdb3 to 45abee7
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.