Skip to content
This repository was archived by the owner on Aug 16, 2022. It is now read-only.

Conversation

@aetter
Copy link
Contributor

@aetter aetter commented Mar 15, 2019

Also covers password changes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Also covers password changes.
@aetter aetter requested a review from elfisher March 15, 2019 21:50
@aetter
Copy link
Contributor Author

aetter commented Mar 15, 2019

Copy link

@elfisher elfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look's good overall. There are a couple of small change requests. Let me know if you have questions.
Thanks!

@elfisher elfisher self-requested a review March 15, 2019 23:56
@elfisher
Copy link

@aetter looks good to me :shipit:

@aetter aetter merged commit 6c8e3ab into master Mar 18, 2019
@aetter aetter deleted the docker-certificate-overrides branch March 18, 2019 15:29
@aetter aetter mentioned this pull request Mar 18, 2019
aetter pushed a commit that referenced this pull request Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants