This repository was archived by the owner on Aug 16, 2022. It is now read-only.
High cardinality #332
Merged
High cardinality #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinkumar12345
added
the
upcoming release
sean-zheng-amazon
left a comment
sean-zheng-amazon
left a comment
There was a problem hiding this comment.
overall looks good, please see comments inline.
ylwu-amzn
reviewed
Oct 27, 2020
ylwu-amzn
reviewed
Oct 27, 2020
|
|
||
| Set the number of aggregation intervals from your data stream to consider in a detection window. We recommend you choose this value based on your actual data to see which one leads to the best results for your use case. | ||
|
|
||
| Based on experiments performed on a wide variety of one-dimensional data streams, we recommend using a window size between 1 and 16. The default window size is 8. |
There was a problem hiding this comment.
The default window size (shingle size at the backend?) is different for single-entity and high cardinality detector.
single-entity: 8
high cardinality: 4
There was a problem hiding this comment.
Sorry, seems we have changed to 1, but there is a TODO saying will change to 4, https://github.com/opendistro-for-elasticsearch/anomaly-detection/blob/5093c8a4df09fe665fe93eb6e5a994206adcfc2b/src/main/java/com/amazon/opendistroforelasticsearch/ad/settings/AnomalyDetectorSettings.java#L233
@kaituo can you confirm?
There was a problem hiding this comment.
yeah, high cardinality detector's shingle size is 1 now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.