Skip to content

chore(bd-tag): add cstor allowed bd tag annotation key#69

Merged
mittachaitu merged 2 commits intoopenebs-archive:masterfrom
sonasingh46:bd-tag-patch
Sep 8, 2020
Merged

chore(bd-tag): add cstor allowed bd tag annotation key#69
mittachaitu merged 2 commits intoopenebs-archive:masterfrom
sonasingh46:bd-tag-patch

Conversation

@sonasingh46
Copy link
Copy Markdown
Contributor

Signed-off-by: Ashutosh Kumar ashutosh.kumar@mayadata.io

Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
@sonasingh46 sonasingh46 requested a review from akhilerm September 7, 2020 09:56
Comment thread pkg/apis/types/types.go Outdated
Copy link
Copy Markdown
Contributor

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small typo in the annotation key. @sonasingh46 . Also I prefer to use the key from this repo in the other PR also.

Signed-off-by: Ashutosh Kumar <ashutosh.kumar@mayadata.io>
Copy link
Copy Markdown

@mittachaitu mittachaitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good

Copy link
Copy Markdown
Contributor

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants