feat(reconcile, controller): disable reconciliation on custom resources#307
Merged
kmova merged 3 commits intoopenebs-archive:masterfrom Dec 4, 2019
Merged
Conversation
akhilerm
force-pushed
the
disable-reconcilation
branch
from
bd39415 to
59a0845
Compare
Codecov Report
@@ Coverage Diff @@
## master #307 +/- ##
==========================================
+ Coverage 51.22% 51.51% +0.29%
==========================================
Files 55 55
Lines 2612 2634 +22
==========================================
+ Hits 1338 1357 +19
+ Misses 1171 1170 -1
- Partials 103 107 +4
Continue to review full report at Codecov.
|
akhilerm
changed the title
kmova
changed the title
`openebs.io/reconcile: "false"` annotation can be set on BlockDevice, Disk and BlockDeviceClaim custom resources to stop reconcilation of those resources. Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
add functionality to disable reconcilation from daemon also. When the annotation is specified, the daemon also will not update the details into the disk and blockdevice resource. Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
akhilerm
force-pushed
the
disable-reconcilation
branch
from
a18a2ed to
609f2a3
Compare
akhilerm
changed the title
kmova
approved these changes
Dec 4, 2019
akhilerm
added a commit
to akhilerm/node-disk-manager
that referenced
this pull request
Dec 4, 2019
…es (openebs-archive#307) `openebs.io/reconcile: "false"` annotation can be set on BlockDevice, Disk and BlockDeviceClaim custom resources to stop reconcilation of those resources. add functionality to disable reconcilation from daemon also. When the annotation is specified, the daemon also will not update the details into the disk and blockdevice resource. Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
kmova
pushed a commit
that referenced
this pull request
Dec 4, 2019
…es (#307) `openebs.io/reconcile: "false"` annotation can be set on BlockDevice, Disk and BlockDeviceClaim custom resources to stop reconcilation of those resources. add functionality to disable reconcilation from daemon also. When the annotation is specified, the daemon also will not update the details into the disk and blockdevice resource. Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openebs.io/reconcile: "false"annotation can be set on BlockDevice, Disk and BlockDeviceClaim custom resources to stop reconciliation of those resources.Disabling reconciliation is useful while handling upgrades. No updates will be done on the Disk, BDs, BDCs etc if the reconciliation is disabled. This means that both the NDM operator and the NDM daemon will not be updating the Disk and BlockDevice resource when the reconcile annotation is set.
Signed-off-by: Akhil Mohan akhil.mohan@mayadata.io