Skip to content

fix(tools): set the default tag to latest for helper pod#351

Merged
akhilerm merged 1 commit intoopenebs-archive:masterfrom
kmova:update-default-helper-pod-image
Nov 29, 2019
Merged

fix(tools): set the default tag to latest for helper pod#351
akhilerm merged 1 commit intoopenebs-archive:masterfrom
kmova:update-default-helper-pod-image

Conversation

@kmova
Copy link
Copy Markdown
Contributor

@kmova kmova commented Nov 29, 2019

The default helper pod which can be overridden via the
ENV was set to fixed older version. This can result in
default image to have some security vulnerabilities.

As part of the release process, the helper pod images will
be rebuilt allowing to pull in a image that has fixed
known security vulnerabilities.

Signed-off-by: kmova kiran.mova@mayadata.io

The default helper pod which can be overridden via the
ENV was set to fixed older version. This can result in
default image to have some security vulnerabilities.

As part of the release process, the helper pod images will
be rebuilt allowing to pull in a image that has fixed
known security vulnerabilities.

Signed-off-by: kmova <kiran.mova@mayadata.io>
@kmova kmova added this to the 0.4.5 milestone Nov 29, 2019
@kmova kmova requested a review from akhilerm November 29, 2019 07:25
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 29, 2019

Codecov Report

Merging #351 into master will decrease coverage by 0.49%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #351     +/-   ##
=========================================
- Coverage   51.67%   51.17%   -0.5%     
=========================================
  Files          55       55             
  Lines        2601     2601             
=========================================
- Hits         1344     1331     -13     
- Misses       1159     1169     +10     
- Partials       98      101      +3
Impacted Files Coverage Δ
cmd/ndm_daemonset/probe/eventhandler.go 46.05% <0%> (-7.9%) ⬇️
cmd/ndm_daemonset/probe/udevprobe.go 60.16% <0%> (-5.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ed7454...9fcbb99. Read the comment docs.

Copy link
Copy Markdown
Contributor

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@akhilerm akhilerm merged commit 56a2deb into openebs-archive:master Nov 29, 2019
akhilerm pushed a commit that referenced this pull request Nov 29, 2019
The default helper pod which can be overridden via the
CLEANUP_JOB_IMAGE environment variable was set
to fixed older version. This can result in default image
to have some security vulnerabilities.

As part of the release process, the helper pod images will
be rebuilt allowing to pull in a image that has fixed
known security vulnerabilities.

Signed-off-by: kmova <kiran.mova@mayadata.io>
(cherry picked from commit 56a2deb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants