fix(script): fix changing the system core pattern#358
Merged
kmova merged 3 commits intoopenebs-archive:masterfrom Dec 27, 2019
Merged
fix(script): fix changing the system core pattern#358kmova merged 3 commits intoopenebs-archive:masterfrom
kmova merged 3 commits intoopenebs-archive:masterfrom
Conversation
earlier NDM used to rewrite the system core pattern so that the core dump is available in the persistent /var/openebs/sparse directory. But this will cause all process to write core files to that directory. Now NDM process will be launched from the openebs directory, so core files will get automatically written to the $PWD. This will help to remove changing the system core pattern. Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
=========================================
- Coverage 51.51% 51.02% -0.5%
=========================================
Files 55 55
Lines 2634 2634
=========================================
- Hits 1357 1344 -13
- Misses 1170 1180 +10
- Partials 107 110 +3
Continue to review full report at Codecov.
|
kmova
approved these changes
Dec 27, 2019
pawanpraka1
reviewed
Dec 30, 2019
| echo "[entrypoint.sh] creating /var/openebs/sparse if not exists." | ||
| mkdir -p /var/openebs/sparse | ||
| echo "[entrypoint.sh] changing directory to /var/openebs/sparse" | ||
| cd /var/openebs/sparse || exit |
Contributor
There was a problem hiding this comment.
will it work if SPARSE_FILE_DIR env is different than /var/openebs/sparse? should we use SPARSE_FILE_DIR env instead /var/openebs/sparse?
Contributor
Author
There was a problem hiding this comment.
Only the mountPath is dependent. SPARSE_FILE_DIR is the directory inside the container .
Contributor
There was a problem hiding this comment.
right, so if I have changed that path to something else what will happen? since in the entrypint.sh it is fixed to /var/openebs/sparse.
Contributor
Author
There was a problem hiding this comment.
if the mountPath is also changed, the core dump wont be persisted. Will raise a PR to fix it. The SPARSE_FILE_DIR and mountPath should always be the same.
akhilerm
added a commit
to akhilerm/node-disk-manager
that referenced
this pull request
Jan 3, 2020
…rchive#358) Earlier NDM used to rewrite the system core pattern so that the core dump is available in the persistent /var/openebs/sparse directory. But this will cause all process to write core files to that directory. Now NDM process will be launched from the openebs directory, so core files will get automatically written to the $PWD. This will help to remove changing the system core pattern. Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
kmova
pushed a commit
that referenced
this pull request
Jan 6, 2020
Earlier NDM used to rewrite the system core pattern so that the core dump is available in the persistent /var/openebs/sparse directory. But this will cause all process to write core files to that directory. Now NDM process will be launched from the openebs directory, so core files will get automatically written to the $PWD. This will help to remove changing the system core pattern. Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier NDM used to rewrite the system core pattern so that the core
dump is available in the persistent
/var/openebs/sparsedirectory.But this will cause all process on the host to write core files to that directory.
Now NDM process will be launched from the openebs directory, so core
files will get automatically written to the
$PWD. This will help toremove changing the system core pattern.
Signed-off-by: Akhil Mohan akhil.mohan@mayadata.io