Skip to content

fix(script): disable coredump in NDM daemon#359

Merged
kmova merged 2 commits intoopenebs-archive:masterfrom
akhilerm:core-dump-fix
Jan 4, 2020
Merged

fix(script): disable coredump in NDM daemon#359
kmova merged 2 commits intoopenebs-archive:masterfrom
akhilerm:core-dump-fix

Conversation

@akhilerm
Copy link
Copy Markdown
Contributor

@akhilerm akhilerm commented Jan 3, 2020

disable coredump from NDM daemon by default. ENABLE_COREDUMP env needs to be used to enable core dump. When core dump is enabled, the ulimit will be set to unlimited and a core directory will be created inside SPARSE_FILE_DIR to store the core files.

disable coredump from NDM daemon by default. `ENABLE_COREDUMP` env
needs to be used to enable core dump. When core dump is enabled, the
ulimit will be set to unlimited and a core directory will be created
inside `SPARSE_FILE_DIR` to store the core files.

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 3, 2020

Codecov Report

Merging #359 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #359   +/-   ##
=======================================
  Coverage   51.49%   51.49%           
=======================================
  Files          55       55           
  Lines        2637     2637           
=======================================
  Hits         1358     1358           
  Misses       1172     1172           
  Partials      107      107

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3d70dd...afd1153. Read the comment docs.

Copy link
Copy Markdown
Contributor

@pawanpraka1 pawanpraka1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@kmova kmova merged commit ff7c7e9 into openebs-archive:master Jan 4, 2020
akhilerm added a commit to akhilerm/node-disk-manager that referenced this pull request Jan 5, 2020
disable coredump from NDM daemon by default. `ENABLE_COREDUMP` env
needs to be used to enable core dump. When core dump is enabled, the
ulimit will be set to unlimited and a core directory will be created
inside `SPARSE_FILE_DIR` to store the core files.

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
kmova pushed a commit that referenced this pull request Jan 6, 2020
disable coredump from NDM daemon by default. `ENABLE_COREDUMP` env
needs to be used to enable core dump. When core dump is enabled, the
ulimit will be set to unlimited and a core directory will be created
inside `SPARSE_FILE_DIR` to store the core files.

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@akhilerm akhilerm deleted the core-dump-fix branch January 6, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants