feat(script, yaml): add openebs basepath#362
Merged
kmova merged 8 commits intoopenebs-archive:masterfrom Feb 1, 2020
Merged
Conversation
vishnuitta
reviewed
Jan 9, 2020
mittachaitu
reviewed
Jan 9, 2020
vishnuitta
reviewed
Jan 9, 2020
pawanpraka1
reviewed
Jan 9, 2020
pawanpraka1
reviewed
Jan 9, 2020
pawanpraka1
reviewed
Jan 9, 2020
akhilerm
force-pushed
the
base-path-fix
branch
from
f71e317 to
56e3669
Compare
Codecov Report
@@ Coverage Diff @@
## master #362 +/- ##
=======================================
- Coverage 51.49% 51% -0.5%
=======================================
Files 55 55
Lines 2637 2637
=======================================
- Hits 1358 1345 -13
- Misses 1172 1182 +10
- Partials 107 110 +3
Continue to review full report at Codecov.
|
akhilerm
requested review from
mittachaitu,
pawanpraka1,
prateekpandey14 and
vishnuitta
akhilerm
changed the title
pawanpraka1
reviewed
Jan 10, 2020
akhilerm
dismissed stale reviews from prateekpandey14, mittachaitu, and vishnuitta
via
73333f5
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
`/var/openebs/ndm` will now be mounted to `/var/openebs/ndm` inside the container. This will prevent multiple sparse directories from being created on the host. Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
akhilerm
force-pushed
the
base-path-fix
branch
from
73333f5 to
e0a8451
Compare
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
akhilerm
requested review from
mittachaitu,
pawanpraka1,
prateekpandey14 and
vishnuitta
mittachaitu
reviewed
Jan 24, 2020
| else | ||
| # making sure mountpath inside the container is available | ||
| if ! [ -d "${NDM_BASE_DIR}" ]; then | ||
| echo "OpenEBS/NDM Base directory not found" |
There was a problem hiding this comment.
I think to represent the message we should use $OPENEBS_BASE_DIR/$NDM_BASE_DIR
Contributor
Author
There was a problem hiding this comment.
NDM_BASE_DIR=OPENEBS_BASE_DIR/ndm. That's why used that error message.
kmova
reviewed
Jan 29, 2020
| export GOTRACEBACK=crash | ||
|
|
||
| # openebs base directory inside the container | ||
| OPENEBS_BASE_DIR="/var/openebs" |
Contributor
Author
There was a problem hiding this comment.
This variable helps to understand how the NDM base path is constructed using the openebs base directory inside the container. Other than that it provides no additional information and is not used.
kmova
approved these changes
Feb 1, 2020
akhilerm
added a commit
to akhilerm/node-disk-manager
that referenced
this pull request
Feb 5, 2020
…hive#362) Make the location for saving the NDM cores inline with other openebs components by providing the location where core's should be saved. The default location is /var/openebs/ndm, which can be changed by passing the right value in the deployment file. Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
kmova
pushed a commit
that referenced
this pull request
Feb 5, 2020
Make the location for saving the NDM cores inline with other openebs components by providing the location where core's should be saved. The default location is /var/openebs/ndm, which can be changed by passing the right value in the deployment file. Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenEBS basepath has been added. Each component of openebs will have a directory under OPENEBS_IO_BASE_DIR on the host machine.
NDM components will be stored under
OPENEBS_IO_BASE_DIR/ndmon the host. Inside the NDM container this path will be mapped to/var/openebs/ndm.