Skip to content

chore(vendor): update the dependencies to latest kubernetes version#365

Merged
kmova merged 3 commits intoopenebs-archive:masterfrom
akhilerm:vendor-update
Jul 22, 2020
Merged

chore(vendor): update the dependencies to latest kubernetes version#365
kmova merged 3 commits intoopenebs-archive:masterfrom
akhilerm:vendor-update

Conversation

@akhilerm
Copy link
Copy Markdown
Contributor

@akhilerm akhilerm commented Jan 20, 2020

update project dependencies

  • kubernetes : v1.17.4
  • controller-runtime : v0.5.2
  • operator-sdk : v0.17.0

@akhilerm akhilerm changed the title chore(vendor): update the dependencies to latest kubernetes version [WIP]chore(vendor): update the dependencies to latest kubernetes version Jan 20, 2020
@akhilerm akhilerm force-pushed the vendor-update branch 2 times, most recently from fc8a1cc to f2b015d Compare January 20, 2020 12:17
@akhilerm akhilerm added this to the 0.5 milestone Mar 11, 2020
@akhilerm akhilerm added pr/hold-merge The PR should not be merged now pr/hold-review Needs rework. labels Mar 17, 2020
@akhilerm akhilerm force-pushed the vendor-update branch 4 times, most recently from 1dfe1b2 to 15a7660 Compare May 11, 2020 13:53
@kmova kmova removed this from the 0.5 milestone Jun 3, 2020
@akhilerm akhilerm changed the title [WIP]chore(vendor): update the dependencies to latest kubernetes version chore(vendor): update the dependencies to latest kubernetes version Jun 8, 2020
@akhilerm akhilerm removed pr/hold-merge The PR should not be merged now pr/hold-review Needs rework. labels Jun 8, 2020
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 8, 2020

Codecov Report

Merging #365 into master will decrease coverage by 0.20%.
The diff coverage is 41.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
- Coverage   44.74%   44.54%   -0.21%     
==========================================
  Files          64       64              
  Lines        2990     3008      +18     
==========================================
+ Hits         1338     1340       +2     
- Misses       1548     1563      +15     
- Partials      104      105       +1     
Impacted Files Coverage Δ
db/kubernetes/client.go 10.16% <0.00%> (-0.36%) ⬇️
...g/controller/blockdevice/blockdevice_controller.go 11.86% <0.00%> (ø)
db/kubernetes/filter.go 50.00% <40.00%> (-50.00%) ⬇️
...er/blockdeviceclaim/blockdeviceclaim_controller.go 40.10% <50.00%> (ø)
cmd/ndm_daemonset/controller/blockdevicestore.go 74.84% <77.77%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fac128...d887de2. Read the comment docs.

@akhilerm akhilerm requested a review from kmova June 9, 2020 05:31
@akhilerm akhilerm added the pr/hold-merge The PR should not be merged now label Jun 9, 2020
@akhilerm akhilerm added this to the 0.7 milestone Jun 9, 2020
@akhilerm akhilerm removed the pr/hold-merge The PR should not be merged now label Jun 9, 2020
RealHarshThakur
RealHarshThakur previously approved these changes Jun 9, 2020
Copy link
Copy Markdown
Contributor

@RealHarshThakur RealHarshThakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kmova
Copy link
Copy Markdown
Contributor

kmova commented Jun 24, 2020

@akhilerm, will hold this till the github action is added to verify multi-arch builds on pull requests. It would be good to ensure that builds don't fail especially on PRs like this that involve a huge changes.

@kmova kmova added the pr/hold-merge The PR should not be merged now label Jun 24, 2020
@akhilerm
Copy link
Copy Markdown
Contributor Author

@kmova , That means we will have to first prioritize the testing and verification using minikube.

Shall we split into 2 things:

  1. We will build multiarch images for each pull request, but will not push it or test it. (node-disk-<component>-ci image will be used). This will guarantee that the build works fine.
  2. Add integration tests using minikube in github actions.

These 2 will be separate PRs and after 1. is merged, we should merge this PR, IMHO

Currently it is not possible to retag images to a different repository using buildx, also mulitarch images cannot stored locally without pushing to an intermediate repository.

As suggested from moby team

... can use intermediate registry or you can just build a single arch for test. after you build multi-arch it will reuse the previous cache.
the advantage of running single arch for tests, is that qemu emulation is slow, so it’s faster to run the test on its native platform.

So the integration tests will be run only on one native platform for now.

@akhilerm akhilerm force-pushed the vendor-update branch 2 times, most recently from 4050841 to f786a54 Compare July 8, 2020 14:20
@akhilerm akhilerm removed the pr/hold-merge The PR should not be merged now label Jul 8, 2020
@akhilerm
Copy link
Copy Markdown
Contributor Author

akhilerm commented Jul 8, 2020

@kmova @harshthakur9030 PTAL.

@RealHarshThakur
Copy link
Copy Markdown
Contributor

@akhilerm LGTM

@akhilerm akhilerm added the pr/hold-merge The PR should not be merged now label Jul 10, 2020
@akhilerm akhilerm removed the pr/hold-merge The PR should not be merged now label Jul 14, 2020
@akhilerm
Copy link
Copy Markdown
Contributor Author

@kmova @harshthakur9030 PTAL. rebased the changes from go version upgrade.

akhilerm added 3 commits July 22, 2020 11:23
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@kmova kmova merged commit a4bb078 into openebs-archive:master Jul 22, 2020
@akhilerm akhilerm deleted the vendor-update branch December 13, 2021 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants