Skip to content

feat(build): enable auto build for arm64 binaries#371

Merged
kmova merged 4 commits intoopenebs-archive:masterfrom
akhilerm:arm-auto-build
Feb 11, 2020
Merged

feat(build): enable auto build for arm64 binaries#371
kmova merged 4 commits intoopenebs-archive:masterfrom
akhilerm:arm-auto-build

Conversation

@akhilerm
Copy link
Copy Markdown
Contributor

  • auto build and push arm64 and amd64 binaries
  • make tests dependent on the platform

shellcheck, unit-tests and integration tests will be run only on amd64, along with the build. On all other platforms the binary will be built and image will be pushed.

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
refactor scripts to setup platform specific integration test infra.

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
refactor build script and ci scripts to work on multiple platforms.
Only on amd64, the unit tests and integration tests will be run.
On all other platforms the binary and docker images will be built
and pushed.

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@akhilerm akhilerm requested a review from kmova February 10, 2020 11:56
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 10, 2020

Codecov Report

Merging #371 into master will decrease coverage by 0.49%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #371     +/-   ##
=======================================
- Coverage   51.49%    51%   -0.5%     
=======================================
  Files          55     55             
  Lines        2637   2637             
=======================================
- Hits         1358   1345     -13     
- Misses       1172   1182     +10     
- Partials      107    110      +3
Impacted Files Coverage Δ
cmd/ndm_daemonset/probe/eventhandler.go 46.05% <0%> (-7.9%) ⬇️
cmd/ndm_daemonset/probe/udevprobe.go 60.3% <0%> (-5.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c858dd...b151e33. Read the comment docs.

Copy link
Copy Markdown
Contributor

@kmova kmova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one. thank you @akhilerm

@kmova kmova merged commit 4ca1c22 into openebs-archive:master Feb 11, 2020
@kmova kmova added this to the 0.4.7 milestone Feb 11, 2020
akhilerm added a commit to akhilerm/node-disk-manager that referenced this pull request Mar 4, 2020
refactor build script and ci scripts to work on multiple platforms.
Only on amd64, the unit tests and integration tests will be run.
On all other platforms, the binary and docker images will be built
and pushed.

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
kmova pushed a commit that referenced this pull request Mar 4, 2020
refactor build script and ci scripts to work on multiple platforms.
Only on amd64, the unit tests and integration tests will be run.
On all other platforms, the binary and docker images will be built
and pushed.

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@akhilerm akhilerm deleted the arm-auto-build branch March 28, 2020 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants