Skip to content

refactor(operator, yaml): remove unused disk CRD#412

Merged
kmova merged 3 commits intoopenebs-archive:masterfrom
akhilerm:stop-disk-installation
May 1, 2020
Merged

refactor(operator, yaml): remove unused disk CRD#412
kmova merged 3 commits intoopenebs-archive:masterfrom
akhilerm:stop-disk-installation

Conversation

@akhilerm
Copy link
Copy Markdown
Contributor

Why is this PR required? What issue does it fix?:
Cleaning up of unused controller code

What this PR does?:
This PR removes unused disk CRD related code (installation and controller) and the related YAMLs.
On fresh installations:

  • Disk CRD will not be installed

Existing installations:

  • Existing disk resources will not be reconciled.

Does this PR require any upgrade changes?:
No

If the changes in this PR are manually verified, list down the scenarios covered::
Updated the v0.4.9 NDM operator and daemonset to an image using the changes. Everything worked fine.

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

remove unused disk CRD related installation steps

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
remove disk CR related YAML

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@akhilerm akhilerm force-pushed the stop-disk-installation branch from 35870cf to 58bcb84 Compare April 30, 2020 18:24
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@akhilerm akhilerm requested a review from kmova April 30, 2020 19:24
@akhilerm akhilerm added the pr/documentation-pending The changes need to be documented label Apr 30, 2020
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #412 into master will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
+ Coverage   46.95%   47.14%   +0.19%     
==========================================
  Files          60       59       -1     
  Lines        2707     2683      -24     
==========================================
- Hits         1271     1265       -6     
+ Misses       1338     1322      -16     
+ Partials       98       96       -2     
Impacted Files Coverage Δ
cmd/ndm_daemonset/controller/controller.go 18.36% <ø> (ø)
...md/ndm_daemonset/controller/sparsefilegenerator.go 87.95% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dbc76c...ef57eda. Read the comment docs.

@kmova kmova merged commit 7808835 into openebs-archive:master May 1, 2020
@akhilerm akhilerm deleted the stop-disk-installation branch May 1, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/documentation-pending The changes need to be documented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants