refactor(operator, yaml): remove unused disk CRD#412
Merged
kmova merged 3 commits intoopenebs-archive:masterfrom May 1, 2020
Merged
refactor(operator, yaml): remove unused disk CRD#412kmova merged 3 commits intoopenebs-archive:masterfrom
kmova merged 3 commits intoopenebs-archive:masterfrom
Conversation
remove unused disk CRD related installation steps Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
remove disk CR related YAML Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
35870cf to
58bcb84
Compare
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Codecov Report
@@ Coverage Diff @@
## master #412 +/- ##
==========================================
+ Coverage 46.95% 47.14% +0.19%
==========================================
Files 60 59 -1
Lines 2707 2683 -24
==========================================
- Hits 1271 1265 -6
+ Misses 1338 1322 -16
+ Partials 98 96 -2
Continue to review full report at Codecov.
|
kmova
approved these changes
May 1, 2020
This was referenced May 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this PR required? What issue does it fix?:
Cleaning up of unused controller code
What this PR does?:
This PR removes unused disk CRD related code (installation and controller) and the related YAMLs.
On fresh installations:
Existing installations:
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Updated the
v0.4.9NDM operator and daemonset to an image using the changes. Everything worked fine.Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>