refactor(code): Exported rescan functionality#455
Merged
akhilerm merged 1 commit intoopenebs-archive:masterfrom Jul 11, 2020
Merged
refactor(code): Exported rescan functionality#455akhilerm merged 1 commit intoopenebs-archive:masterfrom
akhilerm merged 1 commit intoopenebs-archive:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #455 +/- ##
==========================================
- Coverage 43.48% 43.44% -0.04%
==========================================
Files 61 61
Lines 2969 2974 +5
==========================================
+ Hits 1291 1292 +1
- Misses 1576 1579 +3
- Partials 102 103 +1
Continue to review full report at Codecov.
|
akhilerm
reviewed
Jul 10, 2020
7 tasks
kmova
previously approved these changes
Jul 11, 2020
RealHarshThakur
changed the title
akhilerm
reviewed
Jul 11, 2020
Signed-off-by: Harsh Thakur <harshthakur9030@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harsh Thakur harshthakur9030@gmail.com
Pull Request template
Why is this PR required? What issue does it fix?:
This PR exposes the method which is used to sync etcd and ndm local state
What this PR does?:
Exposes rescan method which helps to sync etcd and ndm local state. It also ensures that the udev method being called is thread safe.
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Tested it on a GKE cluster.
Any additional information for your reviewer? :
This is required for the gRPC PR.
Checklist:
<type>(<scope>): <subject>