chore(dependency): Remove gox as a dependency#456
Merged
akhilerm merged 1 commit intoopenebs-archive:masterfrom Jul 13, 2020
Merged
chore(dependency): Remove gox as a dependency#456akhilerm merged 1 commit intoopenebs-archive:masterfrom
akhilerm merged 1 commit intoopenebs-archive:masterfrom
Conversation
7 tasks
akhilerm
reviewed
Jul 10, 2020
akhilerm
reviewed
Jul 10, 2020
akhilerm
suggested changes
Jul 10, 2020
Contributor
akhilerm
left a comment
akhilerm
left a comment
There was a problem hiding this comment.
Has requested some changes related to usage of environment variables.
Codecov Report
@@ Coverage Diff @@
## master #456 +/- ##
=======================================
Coverage 44.74% 44.74%
=======================================
Files 64 64
Lines 2990 2990
=======================================
Hits 1338 1338
Misses 1548 1548
Partials 104 104 Continue to review full report at Codecov.
|
akhilerm
reviewed
Jul 11, 2020
akhilerm
reviewed
Jul 11, 2020
akhilerm
reviewed
Jul 11, 2020
RealHarshThakur
changed the title
akhilerm
reviewed
Jul 11, 2020
kmova
reviewed
Jul 11, 2020
kmova
previously approved these changes
Jul 13, 2020
7 tasks
akhilerm
reviewed
Jul 13, 2020
akhilerm
reviewed
Jul 13, 2020
akhilerm
reviewed
Jul 13, 2020
akhilerm
reviewed
Jul 13, 2020
Contributor
akhilerm
left a comment
akhilerm
left a comment
There was a problem hiding this comment.
@harshthakur9030 given a few more nitpick comments.
Signed-off-by: Harsh Thakur <harshthakur9030@gmail.com>
RealHarshThakur
force-pushed
the
nogox
branch
2 times, most recently
from
d3cfcb5 to
927446c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harsh Thakur harshthakur9030@gmail.com
Pull Request template
Why is this PR required? What issue does it fix?:
Removes gox and builds using native go compiler
What this PR does?:
Replaces gox and builds multi-arch binaries with native go compiler
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Verified that the multi-arch images are built successfully.
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>