feat(dependency): Upgrade go version to 1.14#459
Merged
kmova merged 1 commit intoopenebs-archive:masterfrom Jul 14, 2020
Merged
feat(dependency): Upgrade go version to 1.14#459kmova merged 1 commit intoopenebs-archive:masterfrom
kmova merged 1 commit intoopenebs-archive:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
=======================================
Coverage 44.74% 44.74%
=======================================
Files 64 64
Lines 2990 2990
=======================================
Hits 1338 1338
Misses 1548 1548
Partials 104 104 Continue to review full report at Codecov.
|
RealHarshThakur
force-pushed
the
bumpgo14
branch
2 times, most recently
from
354eff0 to
03ed7da
Compare
akhilerm
reviewed
Jul 14, 2020
akhilerm
reviewed
Jul 14, 2020
akhilerm
reviewed
Jul 14, 2020
Contributor
akhilerm
left a comment
akhilerm
left a comment
There was a problem hiding this comment.
question: have some questions on the modules.txt
Contributor
|
@harshthakur9030 Can you also add a changelog for this version upgrade? |
RealHarshThakur
force-pushed
the
bumpgo14
branch
from
03ed7da to
8d42802
Compare
akhilerm
reviewed
Jul 14, 2020
Signed-off-by: Harsh Thakur <harshthakur9030@gmail.com>
RealHarshThakur
force-pushed
the
bumpgo14
branch
from
8d42802 to
52ff463
Compare
kmova
approved these changes
Jul 14, 2020
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request template
Why is this PR required? What issue does it fix?:
This PR upgrades to go version to 1.14
What this PR does?:
It makes the CI and the repo's go version consistent with each other.
Does this PR require any upgrade changes?:
Yes, go version is upgraded
If the changes in this PR are manually verified, list down the scenarios covered::
Manually built the binary locally
Any additional information for your reviewer? :
Should be merged after removing gox PR as the go.mod file doesn't contain gox as a dependency anymore.
#456
Checklist:
<type>(<scope>): <subject>