chore(build): fix build and push script to remove v prefix#467
Merged
kmova merged 1 commit intoopenebs-archive:masterfrom Aug 4, 2020
Merged
chore(build): fix build and push script to remove v prefix#467kmova merged 1 commit intoopenebs-archive:masterfrom
v prefix#467kmova merged 1 commit intoopenebs-archive:masterfrom
Conversation
Currently the ci images from release branches are having a prefix `v`, eg: `v0.7.x-ci`. But to make naming consistent across all the images we need to use only `0.7.x-ci`. This PR removes the prefix from both the push script as well as the multiarch image. Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
akhilerm
force-pushed
the
remove-v-prefix
branch
from
1b9dbec to
e18ab45
Compare
Codecov Report
@@ Coverage Diff @@
## master #467 +/- ##
==========================================
+ Coverage 42.68% 42.90% +0.21%
==========================================
Files 71 71
Lines 3228 3228
==========================================
+ Hits 1378 1385 +7
+ Misses 1740 1735 -5
+ Partials 110 108 -2
Continue to review full report at Codecov.
|
kmova
approved these changes
Aug 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akhil Mohan akhil.mohan@mayadata.io
Why is this PR required? What issue does it fix?:
Currently the ci images from release branches are having a prefix
v, eg:v0.7.x-ci. But to make naming consistent across all the images we need to use only0.7.x-ci.What this PR does?:
This PR removes the prefix from both the push script as well as the multiarch image.
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
This PR is part of #137 to remove
vprefix from all image tags.Checklist:
<type>(<scope>): <subject>