fix(controller): fix nil pointer dereference in BDC controller due to non existent BD#479
Merged
kmova merged 1 commit intoopenebs-archive:masterfrom Sep 3, 2020
Merged
Conversation
5beb01d to
9e48a7f
Compare
… non existent BD when a Claimed BD is manually deleted by removing the finalizer, and later when the user tries to delete BDC, NDM operator will continuously crash. This because NDM operator tries to release a non existent BD. This change throws an error and add an event to BDC when a corresponding BD cannot be found. Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
9e48a7f to
a868d8e
Compare
Codecov Report
@@ Coverage Diff @@
## master #479 +/- ##
==========================================
- Coverage 40.40% 40.35% -0.05%
==========================================
Files 72 72
Lines 3527 3531 +4
==========================================
Hits 1425 1425
- Misses 1993 1997 +4
Partials 109 109
Continue to review full report at Codecov.
|
kmova
approved these changes
Sep 3, 2020
This was referenced Sep 8, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akhil Mohan akhil.mohan@mayadata.io
Why is this PR required? What issue does it fix?:
When a Claimed BD is manually deleted by removing the finalizer, and later when the user
tries to delete BDC, NDM operator will continuously crash. This because NDM operator
tries to release a non existent BD.
What this PR does?:
adds a check to throw an error when the claimed BD is not found. This PR also adds an event to BDC when BlockDevice is not found.
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>