Skip to content

fix(filter): add check for /dev/mapper path along with /dev/dm- in path filter#518

Merged
kmova merged 5 commits intoopenebs-archive:masterfrom
akhilerm:add-mapper-filter
Dec 7, 2020
Merged

fix(filter): add check for /dev/mapper path along with /dev/dm- in path filter#518
kmova merged 5 commits intoopenebs-archive:masterfrom
akhilerm:add-mapper-filter

Conversation

@akhilerm
Copy link
Copy Markdown
Contributor

@akhilerm akhilerm commented Dec 4, 2020

Why is this PR required? What issue does it fix?:
Most systems use a configured /dev/mapper/<dm-name> rather than the /dev/dm-X to identify dm devices. NDM was only checking for /dev/dm-X path in the path filter which caused issues as mentioned here

What this PR does?:

  • adds check for /dev/mapper along with device path in path filter

Does this PR require any upgrade changes?:
No

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
…ilter

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@akhilerm akhilerm requested a review from kmova December 6, 2020 13:25
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #518 (9a16726) into master (3bebe70) will increase coverage by 0.12%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #518      +/-   ##
==========================================
+ Coverage   47.51%   47.64%   +0.12%     
==========================================
  Files          73       73              
  Lines        3315     3327      +12     
==========================================
+ Hits         1575     1585      +10     
- Misses       1580     1581       +1     
- Partials      160      161       +1     
Impacted Files Coverage Δ
pkg/udev/common.go 87.30% <33.33%> (-2.70%) ⬇️
cmd/ndm_daemonset/filter/pathfilter.go 76.92% <100.00%> (+5.95%) ⬆️
cmd/ndm_daemonset/probe/udevprobe.go 54.74% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bebe70...9a16726. Read the comment docs.

@kmova kmova merged commit 7419480 into openebs-archive:master Dec 7, 2020
akhilerm added a commit to akhilerm/node-disk-manager that referenced this pull request Dec 9, 2020
…th filter (openebs-archive#518)

check for /dev/mapper path along with /dev/dm- in path filter


Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
kmova pushed a commit that referenced this pull request Dec 10, 2020
…th filter (#518)

check for /dev/mapper path along with /dev/dm- in path filter


Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@akhilerm akhilerm deleted the add-mapper-filter branch December 13, 2021 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LVM: Disk filtering on /dev/mapper/<vg>-<lv> or /dev/<vg>/<lv> should be possible

4 participants