fix(filter): add partition and device mapper check to validity filter#519
Merged
kmova merged 3 commits intoopenebs-archive:masterfrom Dec 9, 2020
Merged
Conversation
… filter - add validation check for blockdevices of type partition and device mapper Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
kmova
approved these changes
Dec 9, 2020
akhilerm
added a commit
to akhilerm/node-disk-manager
that referenced
this pull request
Dec 9, 2020
…openebs-archive#519) add validation check for blockdevices of type partition and device mapper Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
kmova
pushed a commit
that referenced
this pull request
Dec 10, 2020
…#519) add validation check for blockdevices of type partition and device mapper Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this PR required? What issue does it fix?:
Repeated udev scan sometimes misses certain fields for devices like partition uuid, dm uuid etc. Since these fields are mandatory for generating the blockdevices unique ID, not having these fields may have issues with wrong blockdevices being created.
What this PR does?:
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>