Skip to content

feat(blockdevice, core): add mpath to supported DM device types#530

Merged
kmova merged 2 commits intoopenebs-archive:masterfrom
akhilerm:add-mpath
Jan 14, 2021
Merged

feat(blockdevice, core): add mpath to supported DM device types#530
kmova merged 2 commits intoopenebs-archive:masterfrom
akhilerm:add-mpath

Conversation

@akhilerm
Copy link
Copy Markdown
Contributor

Signed-off-by: Akhil Mohan akhil.mohan@mayadata.io

Why is this PR required? What issue does it fix?:
If mpath is not added to supported type, NDM will not use the DM_UUID to create a blockdevice UUID, resulting in device identification erroring out.

What this PR does?:

  • add multipath device type to supported DM device types

Does this PR require any upgrade changes?:
No

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

add multipath device type to supported DM device types

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@akhilerm akhilerm requested a review from kmova January 13, 2021 05:04
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 13, 2021

Codecov Report

Merging #530 (ddb2d8e) into master (5f87bea) will decrease coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #530      +/-   ##
==========================================
- Coverage   47.93%   47.72%   -0.21%     
==========================================
  Files          73       73              
  Lines        3363     3363              
==========================================
- Hits         1612     1605       -7     
- Misses       1588     1593       +5     
- Partials      163      165       +2     
Impacted Files Coverage Δ
cmd/ndm_daemonset/probe/eventhandler.go 42.59% <0.00%> (-5.56%) ⬇️
cmd/ndm_daemonset/probe/udevprobe.go 52.51% <0.00%> (-2.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f87bea...ddb2d8e. Read the comment docs.

@kmova kmova merged commit 3902d73 into openebs-archive:master Jan 14, 2021
akhilerm added a commit to akhilerm/node-disk-manager that referenced this pull request Jan 16, 2021
kmova pushed a commit that referenced this pull request Jan 16, 2021
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@akhilerm akhilerm deleted the add-mpath branch December 13, 2021 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants