feat(blockdevice, core): add mpath to supported DM device types#530
Merged
kmova merged 2 commits intoopenebs-archive:masterfrom Jan 14, 2021
Merged
feat(blockdevice, core): add mpath to supported DM device types#530kmova merged 2 commits intoopenebs-archive:masterfrom
kmova merged 2 commits intoopenebs-archive:masterfrom
Conversation
add multipath device type to supported DM device types Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Codecov Report
@@ Coverage Diff @@
## master #530 +/- ##
==========================================
- Coverage 47.93% 47.72% -0.21%
==========================================
Files 73 73
Lines 3363 3363
==========================================
- Hits 1612 1605 -7
- Misses 1588 1593 +5
- Partials 163 165 +2
Continue to review full report at Codecov.
|
kmova
approved these changes
Jan 14, 2021
akhilerm
added a commit
to akhilerm/node-disk-manager
that referenced
this pull request
Jan 16, 2021
…ebs-archive#530) Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
kmova
pushed a commit
that referenced
this pull request
Jan 16, 2021
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akhil Mohan akhil.mohan@mayadata.io
Why is this PR required? What issue does it fix?:
If
mpathis not added to supported type, NDM will not use theDM_UUIDto create a blockdevice UUID, resulting in device identification erroring out.What this PR does?:
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>