Skip to content

feat(feature-gate, test): set default feature gate values when flag not provided and fix integration tests#536

Merged
kmova merged 17 commits intoopenebs-archive:masterfrom
akhilerm:default-feature-gate
Feb 2, 2021
Merged

feat(feature-gate, test): set default feature gate values when flag not provided and fix integration tests#536
kmova merged 17 commits intoopenebs-archive:masterfrom
akhilerm:default-feature-gate

Conversation

@akhilerm
Copy link
Copy Markdown
Contributor

@akhilerm akhilerm commented Jan 18, 2021

Why is this PR required? What issue does it fix?:
Currently the default value for all feature flag is false. This changes adds support to change the default value of feature flags

What this PR does?:

  • change GPTBasedUUID to default
  • fix unit tests
  • fix integration tests to support default feature flag
  • use common set of yamls for deploying

Does this PR require any upgrade changes?:
No

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

@akhilerm akhilerm changed the title feat(feature-gate): set default feature gate values when flag not provided feat(feature-gate, test): set default feature gate values when flag not provided and fix integration tests Jan 18, 2021
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@akhilerm akhilerm force-pushed the default-feature-gate branch from 0f00c31 to ed23334 Compare February 1, 2021 04:01
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@akhilerm akhilerm force-pushed the default-feature-gate branch from fef3852 to 4a0cb73 Compare February 1, 2021 11:39
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@akhilerm akhilerm force-pushed the default-feature-gate branch from ef5bab8 to 99dd74a Compare February 1, 2021 12:22
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 1, 2021

Codecov Report

Merging #536 (b77e1c0) into master (6bfbfe7) will increase coverage by 0.76%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
+ Coverage   47.64%   48.41%   +0.76%     
==========================================
  Files          73       73              
  Lines        3373     3371       -2     
==========================================
+ Hits         1607     1632      +25     
+ Misses       1601     1581      -20     
+ Partials      165      158       -7     
Impacted Files Coverage Δ
pkg/udev/mockdata.go 67.08% <ø> (-0.42%) ⬇️
pkg/features/features.go 100.00% <100.00%> (ø)
cmd/ndm_daemonset/probe/eventhandler.go 38.88% <0.00%> (-3.71%) ⬇️
cmd/ndm_daemonset/probe/smartprobe.go 39.53% <0.00%> (-2.33%) ⬇️
cmd/ndm_daemonset/probe/addhandler.go 74.31% <0.00%> (+3.08%) ⬆️
cmd/ndm_daemonset/probe/udevprobe.go 65.36% <0.00%> (+11.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bfbfe7...b77e1c0. Read the comment docs.

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@akhilerm akhilerm marked this pull request as ready for review February 2, 2021 05:32
@akhilerm akhilerm requested a review from kmova February 2, 2021 05:32
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@kmova kmova merged commit ffc9652 into openebs-archive:master Feb 2, 2021
@akhilerm akhilerm deleted the default-feature-gate branch December 13, 2021 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants