Skip to content

feat(build): add ability to push to multiple registries from github actions#544

Merged
kmova merged 24 commits intoopenebs-archive:masterfrom
akhilerm:use-build-action
Mar 1, 2021
Merged

feat(build): add ability to push to multiple registries from github actions#544
kmova merged 24 commits intoopenebs-archive:masterfrom
akhilerm:use-build-action

Conversation

@akhilerm
Copy link
Copy Markdown
Contributor

@akhilerm akhilerm commented Feb 12, 2021

Why is this PR required? What issue does it fix?:
Currently the multiarch images can be pushed only to a single registry without rebuilding. Therefore the images are by default pushed to docker hub only. This is not ideal and images should be pushed to multiple registries. This PR fixes this issue by making use of the official docker build-push-action.

What this PR does?:

  • make use of docker build-push-action
  • push images to quay

Does this PR require any upgrade changes?:
No

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
QUAY_USERNAME and QUAY_TOKEN secrets need to be added to the repo

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

@akhilerm akhilerm marked this pull request as ready for review February 13, 2021 05:40
Comment thread .github/workflows/release.yml Outdated
Comment thread changelogs/unreleased/544-akhilerm Outdated
Comment thread .github/workflows/build.yml
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 22, 2021

Codecov Report

Merging #544 (89e4ed8) into master (368ef92) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #544   +/-   ##
=======================================
  Coverage   48.41%   48.41%           
=======================================
  Files          73       73           
  Lines        3371     3371           
=======================================
  Hits         1632     1632           
  Misses       1581     1581           
  Partials      158      158           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7196834...e793e5c. Read the comment docs.

@xunholy
Copy link
Copy Markdown
Contributor

xunholy commented Feb 22, 2021

Appears to be CI is failing unit tests - any additional TODOs before this is ready for review?

@akhilerm
Copy link
Copy Markdown
Contributor Author

akhilerm commented Feb 22, 2021

Appears to be CI is failing unit tests - any additional TODOs before this is ready for review?

@xunholy @shubham14bajpai Will fix the unit tests, and mark it ready for review. Till then we will hold the review process.

EDIT: There seems to be a change in the VM provided by github actions, the unit-tests which checks for the OS installation disk are the ones which are failing.

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@akhilerm akhilerm removed the pr/hold-review Needs rework. label Feb 23, 2021
@akhilerm
Copy link
Copy Markdown
Contributor Author

@xunholy @shubham14bajpai Fixed the issue with CI builds.This PR can now be reviewed

Copy link
Copy Markdown
Contributor

@shubham14bajpai shubham14bajpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@xunholy xunholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Nice changes!

@kmova kmova merged commit 81d5a04 into openebs-archive:master Mar 1, 2021
@akhilerm akhilerm deleted the use-build-action branch December 13, 2021 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants