feat(build): add ability to push to multiple registries from github actions#544
feat(build): add ability to push to multiple registries from github actions#544kmova merged 24 commits intoopenebs-archive:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #544 +/- ##
=======================================
Coverage 48.41% 48.41%
=======================================
Files 73 73
Lines 3371 3371
=======================================
Hits 1632 1632
Misses 1581 1581
Partials 158 158 Continue to review full report at Codecov.
|
|
Appears to be CI is failing unit tests - any additional TODOs before this is ready for review? |
@xunholy @shubham14bajpai Will fix the unit tests, and mark it ready for review. Till then we will hold the review process. EDIT: There seems to be a change in the VM provided by github actions, the unit-tests which checks for the OS installation disk are the ones which are failing. |
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
d4bdceb to
e793e5c
Compare
|
@xunholy @shubham14bajpai Fixed the issue with CI builds.This PR can now be reviewed |
Why is this PR required? What issue does it fix?:
Currently the multiarch images can be pushed only to a single registry without rebuilding. Therefore the images are by default pushed to docker hub only. This is not ideal and images should be pushed to multiple registries. This PR fixes this issue by making use of the official docker build-push-action.
What this PR does?:
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
QUAY_USERNAMEandQUAY_TOKENsecrets need to be added to the repoChecklist:
<type>(<scope>): <subject>