fix(event): fix cannot deactive BlockDevice#546
Merged
akhilerm merged 1 commit intoopenebs-archive:masterfrom Mar 1, 2021
Merged
fix(event): fix cannot deactive BlockDevice#546akhilerm merged 1 commit intoopenebs-archive:masterfrom
akhilerm merged 1 commit intoopenebs-archive:masterfrom
Conversation
akhilerm
previously approved these changes
Feb 22, 2021
Contributor
akhilerm
left a comment
akhilerm
left a comment
There was a problem hiding this comment.
LGTM.
@cospotato Can you add a changelog also.
Contributor
Author
|
@akhilerm Added changelog. |
fixed cannot deactive BlockDevice immediately when "unplugged" device with GPTBasedUUID enabled Signed-off-by: cospotato <i@0x233.cn>
Codecov Report
@@ Coverage Diff @@
## master #546 +/- ##
==========================================
+ Coverage 48.41% 48.91% +0.50%
==========================================
Files 73 73
Lines 3371 3365 -6
==========================================
+ Hits 1632 1646 +14
+ Misses 1581 1564 -17
+ Partials 158 155 -3
Continue to review full report at Codecov.
|
Contributor
|
Thank you for this fix @cospotato |
Contributor
Author
|
@akhilerm I'm happy to help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request template
Why is this PR required? What issue does it fix?:
When I unplugged a disk from node, the BlockDevice was not become Inactive immediately until I restart (delete daemonset pod) the daemonset on the node.
What this PR does?:
fix cannot deactive BlockDevice when GPTBasedUUID is enabled
Does this PR require any upgrade changes?:
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>