fix(sysfs): add check for empty devpath#560
Merged
kmova merged 3 commits intoopenebs-archive:masterfrom Apr 5, 2021
Merged
Conversation
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Codecov Report
@@ Coverage Diff @@
## master #560 +/- ##
==========================================
- Coverage 49.39% 48.52% -0.87%
==========================================
Files 73 73
Lines 3365 3367 +2
==========================================
- Hits 1662 1634 -28
- Misses 1548 1578 +30
Partials 155 155
Continue to review full report at Codecov.
|
RealHarshThakur
approved these changes
Apr 3, 2021
kmova
approved these changes
Apr 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akhil Mohan akhil.mohan@mayadata.io
Why is this PR required? What issue does it fix?:
If the devpath received due to some error is empty, then sysfs device creation caused a crash. This PR adds a check for empty path before creating a sysfs device.
What this PR does?:
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>