fix(pkg, mount): fetch all mount points for a given device#590
fix(pkg, mount): fetch all mount points for a given device#590RealHarshThakur merged 1 commit intoopenebs-archive:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #590 +/- ##
==========================================
+ Coverage 49.47% 49.56% +0.09%
==========================================
Files 73 73
Lines 3359 3371 +12
==========================================
+ Hits 1662 1671 +9
- Misses 1541 1545 +4
+ Partials 156 155 -1
Continue to review full report at Codecov.
|
z0marlin
changed the title
|
@z0marlin Can you check the DCO Sign Off? |
The DCO check is passing. Have I missed something? |
Nope. Its good now. |
| } | ||
| if mountAttr, ok := fn(line); ok { | ||
| return mountAttr, nil | ||
| if lineMountAttr, ok := fn(line); ok { |
There was a problem hiding this comment.
Here fn can either be either getPartitionName or getMountName. Can you test the new approach works in both cases and does not break the existing implementation
z0marlin
force-pushed
the
multi-mps
branch
2 times, most recently
from
2949f32 to
9406b24
Compare
|
@z0marlin Changes we discussed in the issue related to adding field in CRD, would that be a separate PR ? |
|
I think yes. I'm still waiting on a confirmation to make the changes in CRD. Have broken down the issue into two tasks for the same reason. @RealHarshThakur |
|
@z0marlin Can you add the changelog to this PR? |
|
@z0marlin Can you fix the conflicts in this PR? |
partitions can be mounted at multiple points in a given system. return a list of all the mount points of a given device as found in the mounts file instead of just returning the first entry. Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
5 participants
Partitions can be mounted at multiple points in a given system.
Return a list of all the mount points of a given device as found in the
mounts file instead of just returning the first entry.
Signed-off-by: Aditya Jain aditya.jainadityajain.jain@gmail.com
Checklist:
<type>(<scope>): <subject>