skip delete disk partition event when GPTBasedUUID is disable#639
skip delete disk partition event when GPTBasedUUID is disable#639akhilerm merged 12 commits intoopenebs-archive:developfrom liuminjian:develop
Conversation
Signed-off-by: liuminjian <liuminjian@d-uni.com>
Signed-off-by: liuminjian <liuminjian@d-uni.com>
Signed-off-by: liuminjian <liuminjian@d-uni.com>
Codecov Report
@@ Coverage Diff @@
## develop #639 +/- ##
===========================================
- Coverage 46.93% 46.89% -0.04%
===========================================
Files 78 78
Lines 3814 3817 +3
===========================================
Hits 1790 1790
- Misses 1866 1869 +3
Partials 158 158
Continue to review full report at Codecov.
|
akhilerm
left a comment
There was a problem hiding this comment.
Seeing a change in the default disabled feature gate, I am thinking if the legacy method of disk identification is still used?? Are there any use cases for which you need the legacy method?
Signed-off-by: liuminjian <liuminjian@d-uni.com>
akhilerm
left a comment
There was a problem hiding this comment.
@liuminjian Can you separate the changes for adding zpool label into a different PR.
The changes in the skipping delete partition event are good.
akhilerm
left a comment
There was a problem hiding this comment.
@liuminjian Given one more comment
|
OK,i separate the changes for adding zpool label into a different PR |
Signed-off-by: liuminjian <liuminjian@chinatelecom.cn>
Signed-off-by: liuminjian <liuminjian@chinatelecom.cn>
Signed-off-by: liuminjian <liuminjian@chinatelecom.cn>
akhilerm
left a comment
There was a problem hiding this comment.
LGTM. Thanks @liuminjian for fixing this.
|
@liuminjian Can you also add a changelog as mentioned here |
Signed-off-by: liuminjian <liuminjian@chinatelecom.cn>
z0marlin
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this @liuminjian

Pull Request template
Why is this PR required? What issue does it fix?:
I have a situation,GPTBasedUUID feature is disable,i use the block device by local pv and i partition the disk. the block device will be set inactived when receive a event for partition remove, because the disk and the disk partition have the same block device uuid which generate by ID_WWN ID_VENDOR ID_MODEL ID_SERIAL. so it should skip delete disk partition event when GPTBasedUUID is disable.
What this PR does?:
Does this PR require any upgrade changes?:
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>PLEASE REMOVE BELOW INFORMATION BEFORE SUBMITTING
The PR title message must follow convention:
<type>(<scope>): <subject>.Where:
Most common types are:
*
feat- for new features, not a new feature for build script*
fix- for bug fixes or improvements, not a fix for build script*
chore- changes not related to production code*
docs- changes related to documentation*
style- formatting, missing semi colons, linting fix etc; no significant production code changes*
test- adding missing tests, refactoring tests; no production code change*
refactor- refactoring production code, eg. renaming a variable or function name, there should not be any significant production code changes*
cherry-pick- if PR is merged in master branch and raised to release branch(like v0.4.x)IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.