Enhance the details storage on BD when the device has zpool#643
Merged
akhilerm merged 1 commit intoopenebs-archive:developfrom Sep 18, 2021
liuminjian:zfsdetail
Merged
Enhance the details storage on BD when the device has zpool#643akhilerm merged 1 commit intoopenebs-archive:developfrom liuminjian:zfsdetail
akhilerm merged 1 commit intoopenebs-archive:developfrom
liuminjian:zfsdetail
Conversation
Signed-off-by: liuminjian <liuminjian@d-uni.com> Signed-off-by: liuminjian <liuminjian@chinatelecom.cn>
Codecov Report
@@ Coverage Diff @@
## master #643 +/- ##
==========================================
+ Coverage 46.38% 46.73% +0.34%
==========================================
Files 78 78
Lines 3781 3817 +36
==========================================
+ Hits 1754 1784 +30
- Misses 1871 1879 +8
+ Partials 156 154 -2
Continue to review full report at Codecov.
|
akhilerm
reviewed
Sep 14, 2021
akhilerm
reviewed
Sep 14, 2021
akhilerm
reviewed
Sep 14, 2021
Contributor
akhilerm
left a comment
There was a problem hiding this comment.
@liuminjian Should the label be added to the blockdevice even when the device is being used by openebs cstor?
Or is it needed only when the device is used by kernel zfs? cc: @kmova
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: liuminjian liuminjian@chinatelecom.cn
Pull Request template
Why is this PR required? What issue does it fix?:
#638 Enhance the details storage on BD when the device has zpool
What this PR does?:
Does this PR require any upgrade changes?:
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>PLEASE REMOVE BELOW INFORMATION BEFORE SUBMITTING
The PR title message must follow convention:
<type>(<scope>): <subject>.Where:
Most common types are:
*
feat- for new features, not a new feature for build script*
fix- for bug fixes or improvements, not a fix for build script*
chore- changes not related to production code*
docs- changes related to documentation*
style- formatting, missing semi colons, linting fix etc; no significant production code changes*
test- adding missing tests, refactoring tests; no production code change*
refactor- refactoring production code, eg. renaming a variable or function name, there should not be any significant production code changes*
cherry-pick- if PR is merged in master branch and raised to release branch(like v0.4.x)IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.