Skip to content

Enhance the details storage on BD when the device has zpool#643

Merged
akhilerm merged 1 commit intoopenebs-archive:developfrom
liuminjian:zfsdetail
Sep 18, 2021
Merged

Enhance the details storage on BD when the device has zpool#643
akhilerm merged 1 commit intoopenebs-archive:developfrom
liuminjian:zfsdetail

Conversation

@liuminjian
Copy link
Copy Markdown
Contributor

Signed-off-by: liuminjian liuminjian@chinatelecom.cn

Pull Request template

Why is this PR required? What issue does it fix?:
#638 Enhance the details storage on BD when the device has zpool
What this PR does?:

  1. add file type field for zfs block device
  2. add zpool name label for zfs block device
    image

Does this PR require any upgrade changes?:

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

PLEASE REMOVE BELOW INFORMATION BEFORE SUBMITTING

The PR title message must follow convention:
<type>(<scope>): <subject>.

Where:
Most common types are:
* feat - for new features, not a new feature for build script
* fix - for bug fixes or improvements, not a fix for build script
* chore - changes not related to production code
* docs - changes related to documentation
* style - formatting, missing semi colons, linting fix etc; no significant production code changes
* test - adding missing tests, refactoring tests; no production code change
* refactor - refactoring production code, eg. renaming a variable or function name, there should not be any significant production code changes
* cherry-pick - if PR is merged in master branch and raised to release branch(like v0.4.x)

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Signed-off-by: liuminjian <liuminjian@d-uni.com>
Signed-off-by: liuminjian <liuminjian@chinatelecom.cn>
@kmova kmova requested review from akhilerm and z0marlin September 10, 2021 05:52
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 10, 2021

Codecov Report

Merging #643 (9006e7c) into master (816bf0c) will increase coverage by 0.34%.
The diff coverage is 12.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #643      +/-   ##
==========================================
+ Coverage   46.38%   46.73%   +0.34%     
==========================================
  Files          78       78              
  Lines        3781     3817      +36     
==========================================
+ Hits         1754     1784      +30     
- Misses       1871     1879       +8     
+ Partials      156      154       -2     
Impacted Files Coverage Δ
cmd/ndm_daemonset/controller/controller.go 14.63% <ø> (ø)
cmd/ndm_daemonset/probe/changehandler.go 0.00% <0.00%> (ø)
cmd/ndm_daemonset/probe/eventhandler.go 38.88% <0.00%> (+8.33%) ⬆️
cmd/ndm_daemonset/probe/mountprobe.go 19.58% <0.00%> (-0.63%) ⬇️
cmd/ndm_daemonset/probe/sysfsprobe.go 0.00% <0.00%> (ø)
cmd/ndm_daemonset/probe/usedbyprobe.go 15.11% <0.00%> (-0.55%) ⬇️
pkg/features/features.go 100.00% <ø> (ø)
cmd/ndm_daemonset/probe/udevprobe.go 50.19% <21.05%> (+1.66%) ⬆️
pkg/epoll/epoll.go 62.50% <42.85%> (-1.98%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fbcfa8...9006e7c. Read the comment docs.

Comment thread cmd/ndm_daemonset/probe/usedbyprobe.go
Comment thread pkg/blkid/blkid.go
Copy link
Copy Markdown
Contributor

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liuminjian Should the label be added to the blockdevice even when the device is being used by openebs cstor?

Or is it needed only when the device is used by kernel zfs? cc: @kmova

Copy link
Copy Markdown
Contributor

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@z0marlin z0marlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akhilerm akhilerm merged commit 4b09fda into openebs-archive:develop Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants