fix(cleaner): add /dev mount to cleanup job#649
Merged
kmova merged 2 commits intoopenebs-archive:developfrom Sep 21, 2021
Merged
fix(cleaner): add /dev mount to cleanup job#649kmova merged 2 commits intoopenebs-archive:developfrom
kmova merged 2 commits intoopenebs-archive:developfrom
Conversation
mount /dev directory from host inside the container, so that wipefs performed on the disk generates a corresponding udev change event and the change is reflected on the host also. Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Codecov Report
@@ Coverage Diff @@
## develop #649 +/- ##
===========================================
+ Coverage 45.99% 46.30% +0.31%
===========================================
Files 78 78
Lines 3820 3820
===========================================
+ Hits 1757 1769 +12
+ Misses 1905 1890 -15
- Partials 158 161 +3
Continue to review full report at Codecov.
|
RealHarshThakur
approved these changes
Sep 20, 2021
kmova
approved these changes
Sep 21, 2021
z0marlin
pushed a commit
to akhilerm/node-disk-manager
that referenced
this pull request
Sep 22, 2021
mount /dev directory from host inside the container, so that wipefs performed on the disk generates a corresponding udev change event and the change is reflected on the host also. Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
akhilerm
added a commit
to akhilerm/node-disk-manager
that referenced
this pull request
Sep 24, 2021
mount /dev directory from host inside the container, so that wipefs performed on the disk generates a corresponding udev change event and the change is reflected on the host also. Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
kmova
pushed a commit
that referenced
this pull request
Sep 24, 2021
mount /dev directory from host inside the container, so that wipefs performed on the disk generates a corresponding udev change event and the change is reflected on the host also. Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akhil Mohan akhil.mohan@mayadata.io
What this PR does?:
mount /dev directory from host inside the container, so that wipefs
performed on the disk generates a corresponding udev change event and
the change is reflected on the host also.
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>