Skip to content

[production][Cherry-pick] #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
qiell merged 4 commits into from
Feb 7, 2020
Merged

[production][Cherry-pick] #179

qiell merged 4 commits into from
Feb 7, 2020

Conversation

@ibreakthecloud
Copy link

@ibreakthecloud ibreakthecloud commented Feb 7, 2020 •
edited
Loading

  • add zenMode
  • replace openebs dockerhub to mayadataio

ibreakthecloud and others added 4 commits February 7, 2020 16:46
Add support for zen mode in scope
65ded1f 
zenMode: This is the mode where scope will render just the topology, no
header and footer, ideal for scope with smaller iframe(embedded frames)

- Add a flag `zenMode` and read from URL
- (future-scope): Add support for keyboard shortcut to toggle

Signed-off-by: ibreakthecloud <harshvardhan.karn@mayadata.io>
Add code comment for zenMode
44bd7be 
- This commit adds the code comment in root.js for zenMode and it's
  usage

Signed-off-by: ibreakthecloud <harshvardhan.karn@mayadata.io>
remove trailing space from commit
a62f8dd
@qiell
Change docker org to mayadataio from openebs (#178)
7ac96c6 
Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
qiell
qiell approved these changes Feb 7, 2020
View reviewed changes
Copy link

@qiell qiell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Feb 7, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 2206

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4230 unchanged lines in 3 files lost coverage.
  • Overall coverage remained the same at 26.656%
Files with Coverage Reduction New Missed Lines %
app/multitenant/consul_client.go 3 51.92%
render/detailed/detailed.codecgen.go 1672 28.65%
report/report.codecgen.go 2555 34.96%
Totals Coverage Status
Change from base Build 2141: 0.0%
Covered Lines: 14933
Relevant Lines: 56021
💛 - Coveralls

@qiell qiell merged commit 8d33e39 into mayadata-io:production Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@satyamz satyamz Awaiting requested review from satyamz

1 more reviewer

@qiell qiell qiell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ibreakthecloud @coveralls @qiell