feat!: updated frontend-build & frontend-platform major versions #22
Conversation
package.json
Outdated
| "@edx/frontend-platform": "8.0.0", | ||
| "@openedx/frontend-build": "14.0.3", |
There was a problem hiding this comment.
Is there a specific reason to pin these at exact versions instead of ^ versions?
| "@edx/frontend-platform": "8.0.0", | |
| "@openedx/frontend-build": "14.0.3", | |
| "@edx/frontend-platform": "^8.0.0", | |
| "@openedx/frontend-build": "^14.0.3", |
There was a problem hiding this comment.
No specific reason, I have made the required update
brian-smith-tcril
left a comment
brian-smith-tcril
left a comment
There was a problem hiding this comment.
I left a comment about pinned versions in devDependencies but I consider that a non-blocking request. This LGTM!
|
I do not have the merge rights, @brian-smith-tcril can you please merge it? |
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
| "@edx/frontend-platform": "^8.0.0", | ||
| "@openedx/frontend-build": "^14.0.0", |
There was a problem hiding this comment.
These should have been changed to
"@edx/frontend-platform": "^7.0.1 || ^8.0.0",
"@openedx/frontend-build": "^13.0.27 || ^14.0.0",
Any of the package complete deprecation will make the other project break, thus a breaking change. This change should have bump it to version 3.0.0 instead of 2.1.0
There was a problem hiding this comment.
This was supposed to go as a breaking change as per description, it was reverted immediately and republished as a breaking change
|
@leangseu-edx these changes were reverted and released as breaking change in #24 |
|
@abdullahwaheed Yes. However, |
|
@BilalQamar95 @abdullahwaheed I added a pr for manual release. #25 I don't think it is possible to release the patch |
6 participants
Description
frontend-buildtov14&frontend-platformtov8jesttov29Breaking Change: Due to peerDependency upgrades these packages upgrades are to be released as a breaking change