Release to pypi #95
Merged
Release to pypi #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamsobanjaved
force-pushed
the
pypi-release
branch
2 times, most recently
from
2c07f7e to
8bfe38f
Compare
iamsobanjaved
force-pushed
the
pypi-release
branch
from
8bfe38f to
bd17118
Compare
mraarif
reviewed
Mar 16, 2021
.github/workflows/pypi-release.yml
Outdated
| uses: pypa/gh-action-pypi-publish@master | ||
| with: | ||
| user: __token__ | ||
| password: ${{ secrets.PYPI_UPLOAD_TOKEN }} No newline at end of file |
mraarif
approved these changes
Mar 17, 2021
kdmccormick
approved these changes
Apr 14, 2021
Member
kdmccormick
left a comment
kdmccormick
left a comment
There was a problem hiding this comment.
Looks good; thanks @iamsobanjaved .
One request - when you squash & merge, please revise the commit message to a conventional commit message. Something like:
build: release to pypi
add a GitHub action to push release to PyPI.
BOM-1873
add a GitHub action to push release to PyPI. BOM-1873
iamsobanjaved
force-pushed
the
pypi-release
branch
from
302a632 to
6f77bcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://openedx.atlassian.net/browse/BOM-1873