Skip to content

Conversation

@feanil
Copy link
Contributor

@feanil feanil commented Feb 10, 2025

No description provided.

@feanil feanil closed this Feb 10, 2025
@feanil feanil reopened this Feb 10, 2025
We didn't do this before so not gonna add it just yet.  First we'll get
the build working at all and then we can come back and fix the warnings
before enabling this to prevent future issues.
@feanil feanil merged commit 7755284 into master Feb 10, 2025
8 checks passed
@feanil feanil deleted the feanil/correct_docs_build branch February 10, 2025 17:56
@regisb
Copy link
Contributor

regisb commented Feb 11, 2025

Hi Feanil! Next time please squash your commits ;)

@feanil
Copy link
Contributor Author

feanil commented Feb 11, 2025

Did the commits cause an issue somewhere downstream?

@regisb
Copy link
Contributor

regisb commented Feb 24, 2025

No, I'm just picky about the git commit history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants