-
Notifications
You must be signed in to change notification settings - Fork 4
fix(authz): [FC-0099] update roles label in TeamTable
#10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(authz): [FC-0099] update roles label in TeamTable
#10
Conversation
|
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
TeamTable
56f51b4 to
16515df
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10 +/- ##
==========================================
+ Coverage 90.71% 90.76% +0.05%
==========================================
Files 19 19
Lines 183 184 +1
Branches 23 23
==========================================
+ Hits 166 167 +1
Misses 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@arbrandes @jacobo-dominguez-wgu this is a small fix |
jacobo-dominguez-wgu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it on the sandbox and the roles chip looks good to me 👍
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Tested locally and the role names are appearing nicely!
| Header: intl.formatMessage(messages['library.authz.team.table.roles']), | ||
| accessor: 'roles', | ||
| Cell: RolesCell, | ||
| // eslint-disable-next-line react/no-unstable-nested-components |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a huge fan of ignoring eslint rules, but I see this is already being done earlier in this file
frontend-app-admin-console/src/authz-module/libraries-manager/components/TeamTable.tsx
Line 76 in 52fbb7e
| // eslint-disable-next-line react/no-unstable-nested-components |
I created an issue to track this
Fix roles label in team table
This Pr update the chip component in the Team Table to display the name of the roles based on the metadata defined here #5
Before

After