generated from openedx/frontend-template-application
-
Notifications
You must be signed in to change notification settings - Fork 4
feat: [FC-0099] add button & modal for adding new team members #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
0bb49c1
feat: add team roles management and update related hooks and types
bra-i-am de03216
feat: implement add new team member functionality with modal and actions
bra-i-am 7387ed9
test: add some missing tests
bra-i-am b93512a
test: add unit tests for AddNewTeamMemberModal and update context mocks
bra-i-am 7d298d1
test: add toast close functionality and loading state handling in Add…
bra-i-am fbf2680
fix: update LibrariesAuthZTeamView to include canManageTeam check for…
bra-i-am 1e0a652
fix: correct API endpoint paths and update authorization scope format
bra-i-am 9b85aee
refactor: improve error handling & address PR feedback
bra-i-am 3d0cf35
refactor: group AddNewTeamMemberModal in 1 folder
dcoa b10b614
fix: reset modal values to close action
dcoa 58dc7bd
refactor: replace useAddTeamMember with useAssignTeamMembersRole
dcoa 6afc0da
feat: add tooltip
dcoa 0b9c7b5
test: fix test after rebase
dcoa 57ab33c
refactor: enhance user intruction with placeholder
dcoa 398c747
style: remove unnecessary inline style
dcoa fb5e1b8
fix: remove the error style on change the textarea value
dcoa 92e8467
fix: add useState to display toast
dcoa b661b81
fix: remove empty strings from the user input
dcoa a273c49
fix: validate error users to apply style
dcoa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A
getByTextquery would be more focused on what the user sees on screen, since we are moving away from querying from testIdThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for highlighting this, I will manage all that testId refactors in a separate PR, after the ulmo cut.