-
Notifications
You must be signed in to change notification settings - Fork 4
feat(authz): [FC-0099] add roles tab #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7 +/- ##
==========================================
+ Coverage 92.29% 92.44% +0.14%
==========================================
Files 31 31
Lines 454 463 +9
Branches 77 69 -8
==========================================
+ Hits 419 428 +9
Misses 34 34
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eb57121 to
35093b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the roles tab on the sandbox and everything looks fine. The cards look fine and the user counter is correct.
Despite I dont have the information/resources to make sure the permissions rendered are correct.
It would be nice for future iterations to revisit the component declarations to have consistency, I see some components across the repo being declared like:
const ComponentName: FC<ComponentNameProps> = ({ prop1, prop2}) =>
and some others:
const ComponentName = ({ prop1, prop2}: ComponentNameProps) =>.
I will go with the first way.
Anyways, good work!
Yes, I agree that the code style need alignment. I create a issue for that. |
arbrandes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, and the feature seems to do what it purports to. However, I'm seeing an empty title for what I believe is the Library Contributor role:
Is this missing a translation string somewhere? Or does it have something to do with the fact I'm running openedx_authz@0.5.0 in the backend and this PR hasn't been updated accordingly, yet?
|
@arbrandes it is because the collaborator is not updated in the metadata. Here the associated PR #15 |
Roles tab
This PR add the list of available roles for libraries in the corresponding tab.
Warning
This PR depends on #6 and #5 for getting the roles and permissions metadata and the
RoleCard.Changes overview
RoleCardcomponent.Out of scope
Evidence
Testing instructions
npm run devCORS_WHITELISTin both LMS/CMS settings.pyhttp://apps.local.openedx.io:2025/admin-console/authz/libraries/:libraryId/authz/*queries, you can use 2 optionsbaseUrlwith your service and, changegetAuthenticatedHttpClienttogetHttpClientto avoid user checks from the backend.Additional information