-
Notifications
You must be signed in to change notification settings - Fork 4
feat: [FC-0099] Add a new role to a library member #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [FC-0099] Add a new role to a library member #9
Conversation
|
Thanks for the pull request, @bra-i-am! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
|
||
| const { mutate: assignTeamMembersRole, isPending: isAssignTeamMembersRolePending } = useAssignTeamMembersRole(); | ||
|
|
||
| const handleAddTeamMember = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| const handleAddTeamMember = () => { | |
| const handleAddNewRole = () => { |
5f70bfb to
b9074b0
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9 +/- ##
==========================================
+ Coverage 91.89% 92.27% +0.37%
==========================================
Files 28 31 +3
Lines 395 453 +58
Branches 54 66 +12
==========================================
+ Hits 363 418 +55
- Misses 31 34 +3
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…users * fix: the value of LIBRARY_AUTHZ_SCOPE was misspelled
a9fe6b5 to
dc9e486
Compare
|
In my testing this is working really well overall! I did notice the lack of feedback when trying to add a role that a user already has. I see that is mentioned in the PR description as
I'm perfectly fine with it being a follow up issue if it's created on the repo so the |
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning
This PR depends on #6 because it manages the users' roles view
TODO: Add a toast to inform that the current user has already assigned a role
This pull request adds a button and a modal to assign new roles to the users from the users' roles view
Evidence
Screencast.from.15-10-25.17.11.31.webm
Testing instructions
npm run devtutor dev exec lms pip install git+https://github.com/openedx/openedx-authztutor dev exec lms python manage.py lms migrate openedx_authztutor dev exec lms python manage.py lms load_policiesEditbutton at the end of the user rowAdd New Role, fill the form, and click saveAdditional Information
openedx/openedx-authz#45