Skip to content

fix: make learner name capitalized #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2025
Merged

fix: make learner name capitalized #800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2af8070
fix: make learner name capitalized
sundasnoreen12 Aug 12, 2025
e8aa758
test: fixed test cases
sundasnoreen12 Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/discussions/learners/LearnersView.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ describe('LearnersView', () => {
renderComponent();
});

expect(screen.queryByText('learner-1')).toBeInTheDocument();
expect(screen.queryByText('Learner-1')).toBeInTheDocument();
});

test('Most activity should be selected by default for the non-moderator role.', async () => {
Expand Down Expand Up @@ -176,7 +176,7 @@ describe('LearnersView', () => {
const learners = await container.querySelectorAll('.discussion-post');
const firstLearner = learners.item(0);
const learnerAvatar = firstLearner.querySelector('[alt=learner-1]');
const learnerTitle = within(firstLearner).queryByText('learner-1');
const learnerTitle = within(firstLearner).queryByText('Learner-1');
const stats = firstLearner.querySelectorAll('.icon-size');

expect(learners).toHaveLength(3);
Expand Down
3 changes: 2 additions & 1 deletion src/discussions/learners/learner/LearnerCard.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import React, { useContext } from 'react';

import capitalize from 'lodash/capitalize';
import { Link } from 'react-router-dom';

import { Routes } from '../../../data/constants';
Expand Down Expand Up @@ -39,7 +40,7 @@ const LearnerCard = ({ learner }) => {
<div
className="text-truncate font-weight-500 text-primary-500 font-style"
>
{username}
{capitalize(username)}
</div>
</div>
{threads !== null && (
Expand Down